Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node to 16 LTS #2741

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Bump node to 16 LTS #2741

merged 1 commit into from
Oct 19, 2022

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Jul 2, 2022

node 12 is EOL as of 30 April 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022 •
edited
Loading

Codecov Report

Merging #2741 (1e49a76) into main (8b23708) will increase coverage by 7.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
+ Coverage   56.69%   64.38%   +7.69%     
==========================================
  Files         110      166      +56     
  Lines        3457     6060    +2603     
  Branches     1097     1596     +499     
==========================================
+ Hits         1960     3902    +1942     
- Misses       1497     2158     +661
Impacted Files Coverage Δ
data-serving/data-service/src/model/vaccine.ts 100.00% <0.00%> (ø)
...fication/curator-service/api/src/model/database.ts 83.33% <0.00%> (ø)
...n/curator-service/api/src/model/failed_attempts.ts 53.84% <0.00%> (ø)
...ta-serving/data-service/src/model/case-revision.ts 100.00% <0.00%> (ø)
data-serving/data-service/src/model/date-range.ts 100.00% <0.00%> (ø)
...rator-service/api/src/clients/aws-lambda-client.ts 55.00% <0.00%> (ø)
...urator-service/api/src/clients/aws-batch-client.ts 95.83% <0.00%> (ø)
verification/curator-service/api/src/index.ts 83.68% <0.00%> (ø)
...cation/curator-service/api/src/controllers/auth.ts 44.41% <0.00%> (ø)
data-serving/data-service/src/model/source.ts 100.00% <0.00%> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abhidg abhidg force-pushed the ci-node-16 branch 2 times, most recently from bc0f177 to 5c7e722 Compare July 2, 2022 18:36
@abhidg abhidg changed the title ci: bump node to 16 LTS Bump node to 16 LTS Jul 2, 2022
@abhidg abhidg marked this pull request as draft July 2, 2022 18:42
@abhidg abhidg force-pushed the ci-node-16 branch 2 times, most recently from 1e49a76 to b582279 Compare October 18, 2022 22:59
@abhidg abhidg marked this pull request as ready for review October 19, 2022 07:51
@abhidg abhidg added this to the Oberon milestone Oct 19, 2022
@abhidg abhidg merged commit 48faf52 into main Oct 19, 2022
@abhidg abhidg deleted the ci-node-16 branch October 19, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-sheldon jim-sheldon jim-sheldon approved these changes

@maciej-zarzeczny maciej-zarzeczny Awaiting requested review from maciej-zarzeczny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12 Oberon
Development

Successfully merging this pull request may close these issues.
3 participants
@abhidg @codecov-commenter @jim-sheldon